-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Variant URL in Firestore #455
Conversation
Visit the preview URL for this PR (updated for commit bdbcc3a): https://roar-staging--pr455-optional-variant-url-n31u46uo.web.app (expires Wed, 03 Apr 2024 16:20:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
1 flaky test on run #826 ↗︎
Details:
cypress/e2e/participant/default-tests/playButtonGames.cy.js • 1 flaky test
Review all test suite changes for PR #455 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Can you also only write the taskURL
field (in handleNewTaskSubmit
) if isExternalTask.value
is true?
Done, and made some additional refactors as well. |
This PR adds a checkbox control to appending the variant url to the variant parameters when registering a new game variant through the dashboard.