Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Variant URL in Firestore #455

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Optional Variant URL in Firestore #455

merged 5 commits into from
Mar 27, 2024

Conversation

ksmontville
Copy link
Collaborator

This PR adds a checkbox control to appending the variant url to the variant parameters when registering a new game variant through the dashboard.

Copy link

github-actions bot commented Mar 26, 2024

Visit the preview URL for this PR (updated for commit bdbcc3a):

https://roar-staging--pr455-optional-variant-url-n31u46uo.web.app

(expires Wed, 03 Apr 2024 16:20:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Mar 26, 2024

1 flaky test on run #826 ↗︎

0 34 0 0 Flakiness 1

Details:

Tests for PR 455 "Optional Variant URL in Firestore" from commit "bdbcc3ab22a3be...
Project: roar-dashboard-e2e Commit: bdbcc3ab22
Status: Passed Duration: 29:53 💡
Started: Mar 27, 2024 4:23 PM Ended: Mar 27, 2024 4:53 PM
Flakiness  cypress/e2e/participant/default-tests/playButtonGames.cy.js • 1 flaky test

View Output

Test Artifacts
Testing play through of vocab, cva, letter, and multichoice games as a participant > ROAR - Picture Vocabulary Play through Test Test Replay Screenshots

Review all test suite changes for PR #455 ↗︎

Copy link
Contributor

@richford richford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Can you also only write the taskURL field (in handleNewTaskSubmit) if isExternalTask.value is true?

@ksmontville
Copy link
Collaborator Author

Looking good! Can you also only write the taskURL field (in handleNewTaskSubmit) if isExternalTask.value is true?

Done, and made some additional refactors as well.

@richford richford merged commit 9f4ed2d into main Mar 27, 2024
10 of 14 checks passed
@richford richford deleted the optional-variant-url branch March 27, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants