Enh/variant card handles #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit e0baf6b): https://roar-staging--pr438-enh-variant-card-han-dzip7wqj.web.app (expires Wed, 27 Mar 2024 20:01:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
2 flaky tests on run #643 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Testing play through of vocab, cva, letter, and multichoice games as a participant > ROAR - Picture Vocabulary Play through Test |
Test Replay
Screenshots
|
|
playOptionalGames.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Play Optional Games > Plays ROAR - Sentence |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #438 ↗︎
richford
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a button alternative to the click and drag functionality of the task picker. This is for accessibility reasons and for cypress test reasons.
Comments welcome on the UX for the button. I chose to implement this as a right-hand-side button rather than left-hand-side. the left would be more consistent with location for 'card actions', however I couldn't come up with a design that worked for the existing style and only have 1 button rather than 3.