Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification on login screen when capslock is enabled #436

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

kellyel
Copy link
Collaborator

@kellyel kellyel commented Mar 19, 2024

No description provided.

@kellyel kellyel requested a review from richford March 19, 2024 20:25
Copy link

github-actions bot commented Mar 19, 2024

Visit the preview URL for this PR (updated for commit f414275):

https://roar-staging--pr436-enh-capslock-check-so7cgywf.web.app

(expires Wed, 27 Mar 2024 18:43:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Mar 19, 2024

Passing run #628 ↗︎

0 33 0 0 Flakiness 0

Details:

Tests for PR 436 "Add notification on login screen when capslock is enabled" fro...
Project: roar-dashboard-e2e Commit: f41427542c
Status: Passed Duration: 30:13 💡
Started: Mar 20, 2024 6:46 PM Ended: Mar 20, 2024 7:16 PM

Review all test suite changes for PR #436 ↗︎

@richford richford merged commit 73e3685 into main Mar 20, 2024
12 of 14 checks passed
@richford richford deleted the enh/capslock-check branch March 20, 2024 19:55
Copy link

sentry-io bot commented Mar 22, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: t.getModifierState is not a function checkForCapsLock(src/components/auth/SignIn) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants