-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip/Optional Assessments on Individual Reports #426
Conversation
Visit the preview URL for this PR (updated for commit 4f146ba): https://roar-staging--pr426-optional-individual-ni4bfjk4.web.app (expires Tue, 09 Apr 2024 19:46:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
Passing run #931 ↗︎
Details:
Review all test suite changes for PR #426 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @ksmontville. I left some comments/requests below. Also, while viewing the individual score report, I noticed that we are running two nearly identical queries, one for taskData
and one for rawTaskData
. I'd like to dig into this and see if we can get rid of one. I'm happy to cowork to figure that out. Or maybe @lucasxsong can chime in to tell us the original motivation for that.
The two queries for run information should be refactored to just one, as the data returned from |
…ion level; fix cypress tests.
This PR builds out the functionality for displaying optional assessments on individual reports, including exporting reports to PDF.