Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip/Optional Assessments on Individual Reports #426

Merged
merged 36 commits into from
Apr 2, 2024

Conversation

ksmontville
Copy link
Collaborator

This PR builds out the functionality for displaying optional assessments on individual reports, including exporting reports to PDF.

@ksmontville
Copy link
Collaborator Author

image

Copy link

github-actions bot commented Mar 14, 2024

Visit the preview URL for this PR (updated for commit 4f146ba):

https://roar-staging--pr426-optional-individual-ni4bfjk4.web.app

(expires Tue, 09 Apr 2024 19:46:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Mar 14, 2024

Passing run #931 ↗︎

0 34 0 0 Flakiness 0

Details:

Tests for PR 426 "wip/Optional Assessments on Individual Reports" from commit "4...
Project: roar-dashboard-e2e Commit: 4f146ba1ca
Status: Passed Duration: 38:23 💡
Started: Apr 2, 2024 7:48 PM Ended: Apr 2, 2024 8:27 PM

Review all test suite changes for PR #426 ↗︎

Copy link
Contributor

@richford richford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @ksmontville. I left some comments/requests below. Also, while viewing the individual score report, I noticed that we are running two nearly identical queries, one for taskData and one for rawTaskData. I'd like to dig into this and see if we can get rid of one. I'm happy to cowork to figure that out. Or maybe @lucasxsong can chime in to tell us the original motivation for that.

src/pages/IndividualReport.vue Outdated Show resolved Hide resolved
src/pages/IndividualReport.vue Outdated Show resolved Hide resolved
@lucasxsong
Copy link
Collaborator

The two queries for run information should be refactored to just one, as the data returned from rawTaskData encompasses taskData. The queries were there originally when I had adopted the code from Elijah and Kyle, but I had put off refactoring those queries to work on more pertinent tasks.

@richford richford merged commit 7655454 into main Apr 2, 2024
14 checks passed
@richford richford deleted the optional-individual-reports branch April 2, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants