wip/Optional Assessments on Progress Reports #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Visit the preview URL for this PR (updated for commit cbe770e): https://roar-staging--pr422-optional-reports-ekv5zl3k.web.app (expires Thu, 04 Apr 2024 16:40:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
Passing run #853 ↗︎
Details:
Review all test suite changes for PR #422 ↗︎ |
|||||||||||||||
ksmontville
changed the title
richford
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Thanks @ksmontville! I left some suggestions. Also, I think that the order of evaluation for all of the if blocks should be to check for
- completion first
- else if (optional)
- else if (started)
- else (assigned)
My reasoning is that we want to show if a student has completed even if it's optional for them.
richford
approved these changes
Mar 30, 2024
|
@ksmontville , thanks! LGTM. The title still says WIP, but if this is ready, please feel free to merge. |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds out the functionality for displaying optional assessments on progress reports, including exporting scores.