Allow Email login

[kellyel]

This PR adds the ability to log in using a password for email users.

[github-actions]

Visit the preview URL for this PR (updated for commit 92bbe5e):

https://roar-staging--pr412-enh-email-login-nmgpg136.web.app

_{(expires Fri, 15 Mar 2024 23:10:57 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

[richford]

Code review and testing of the PR preview link look good! Could I ask you to add or modify copies tests as well? I realize that the cypress test user will not be able to log in with email link. But maybe we could just write a test that toggles the password box and verifies that it is enabled/disabled.

[cypress]

2 failed tests on run #465 ↗︎

2

24

0

0

0

Details:

Tests for PR 412 "Allow Email login" from commit "92bbe5ef06bd8b352caee070211523...
Project: roar-dashboard-e2e	Commit: 92bbe5ef06
Status: Failed	Duration: 21:14 💡
Started: Mar 8, 2024 11:13 PM	Ended: Mar 8, 2024 11:34 PM

  cypress/e2e/participant/default-tests/playSWR.cy.js • 1 failed test

View Output

Test		Artifacts
Testing playthrough of SWR as a participant > ROAR-Word Playthrough Test		Test Replay Screenshots

  cypress/e2e/partner-admin/default-tests/viewIndividualReport.cy.js • 1 failed test

View Output

Test		Artifacts
The partner admin can view score reports for a given administration. > Selects an administration and views its score report.		Test Replay Screenshots

Review all test suite changes for PR #412 ↗︎

[lucasxsong]

This looks really good! I was testing on staging and noticed that this error prevented me from authing with email, but pulling down the changes and running the login flow on localhost worked.

I had a small design suggestion: would it be possible to style the disabled password input box to look more like the disabled example in the Primevue docs? The current disabled input box works well in dissuading users from trying to enter a password, but I feel that the visual hinting provided by the darkened input background might help users in quickly identifying what mode they are in (email/pw or email/link). What do you think?

[kellyel]

Thanks for the review, Lucas.
Yes, I noticed that too. However that seems to be the case on all staging links right now. It seems firebase does not recognize the staging links as a valid uri. I just don't think that's been set up yet. It might be possible given that we use the firebase hosting github action to generate these.

Yes, I agree with you. I can darken that background right now.