Prep Roam Fluency for Colombia #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit eabd0b5): https://roar-staging--pr407-fluency-colombia-pre-z5lywfk6.web.app (expires Mon, 18 Mar 2024 18:10:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
1 flaky test on run #489 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| The partner admin can view score reports for a given administration. > Selects an administration and views its score report. |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #407 ↗︎
richford
requested changes
Mar 7, 2024
src/components/tasks/TaskFluency.vue
Outdated
| @@ -18,6 +18,7 @@ import { fetchDocById } from '@/helpers/query/utils'; | |||
|
|
|||
| const props = defineProps({ | |||
| taskId: { type: String, required: true, default: 'fluency' }, | |||
There was a problem hiding this comment.
Should the default be 'fluency-arf'
richford
approved these changes
Mar 11, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the routes to pass language into Roam Fluency as a prop, and provides a testing environment for Roam Fluency in preparation for the Colombia Administration.