-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip/Dashboard Internationalization #379
Conversation
Visit the preview URL for this PR (updated for commit dc92b40): https://roar-staging--pr379-internationalization-356ea970.web.app (expires Wed, 06 Mar 2024 20:57:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
Passing run #336 ↗︎
Details:
Review all test suite changes for PR #379 ↗︎ |
@ksmontville, LGTM. I just approved. The title says "WIP" but whenever you feel like this is ready, I think we could merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small nitpicky changes requested, all having to do with the use of @
in import statements. They are so small that I'm approving anyway as I'd be fine merging without them.
One thing for us to discuss is the translation of assent forms. Let's discuss at the all-hands meeting today. That might be out of scope for this PR. |
This PR builds out the foundations for translating the ROAR Dashboard into multiple languages.