Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip/Dashboard Internationalization #379

Merged
merged 29 commits into from
Feb 28, 2024
Merged

wip/Dashboard Internationalization #379

merged 29 commits into from
Feb 28, 2024

Conversation

ksmontville
Copy link
Collaborator

This PR builds out the foundations for translating the ROAR Dashboard into multiple languages.

Copy link

github-actions bot commented Feb 20, 2024

Visit the preview URL for this PR (updated for commit dc92b40):

https://roar-staging--pr379-internationalization-356ea970.web.app

(expires Wed, 06 Mar 2024 20:57:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Feb 20, 2024

Passing run #336 ↗︎

0 24 0 0 Flakiness 0

Details:

Tests for PR 379 "wip/Dashboard Internationalization" from commit "dc92b40824996...
Project: roar-dashboard-e2e Commit: dc92b40824
Status: Passed Duration: 20:16 💡
Started: Feb 28, 2024 9:00 PM Ended: Feb 28, 2024 9:20 PM

Review all test suite changes for PR #379 ↗︎

src/router/index.js Outdated Show resolved Hide resolved
src/router/index.js Outdated Show resolved Hide resolved
src/router/index.js Outdated Show resolved Hide resolved
src/pages/HomeSelector.vue Show resolved Hide resolved
@richford
Copy link
Contributor

@ksmontville, LGTM. I just approved. The title says "WIP" but whenever you feel like this is ready, I think we could merge it.

Copy link
Contributor

@richford richford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small nitpicky changes requested, all having to do with the use of @ in import statements. They are so small that I'm approving anyway as I'd be fine merging without them.

src/main.js Outdated Show resolved Hide resolved
src/router/index.js Outdated Show resolved Hide resolved
src/components/LanguageSelector.vue Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
@richford
Copy link
Contributor

One thing for us to discuss is the translation of assent forms. Let's discuss at the all-hands meeting today. That might be out of scope for this PR.

@ksmontville ksmontville merged commit 6e8006a into main Feb 28, 2024
14 checks passed
@ksmontville ksmontville deleted the internationalization branch February 28, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants