Individual Score Reports #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 2f764bc): https://roar-staging--pr371-enh-individual-score-yh9cylfv.web.app (expires Thu, 14 Mar 2024 21:34:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
1 flaky test on run #441 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Testing playthrough of SWR as a participant > ROAR-Word Playthrough Test |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #371 ↗︎
lucasxsong
force-pushed
the
enh/individual-score-reports
branch
from
86cc6b2
to
3fd85d2
Compare
initial commit initial commit Modifed Page Fetcher function and build individual score reports. Build out individual score reports. Infrastructure for individual reports initial commit Modifed Page Fetcher function and build individual score reports. Styling changes and new formatting functions. Make dynamic with props Fix pagination error on Score Reports. Improve error handling and add support for raw-score-only tasks. Fix route params in datatable Improve error handling Add descriptions to tasks rebase onto main
lucasxsong
force-pushed
the
enh/individual-score-reports
branch
from
eb10455
to
89d35c4
Compare
richford
requested changes
Mar 7, 2024
There was a problem hiding this comment.
This looks really good, @lucasxsong!!! It's really nice to see. I requested some changes. Some are very minor, like linting and deleting obsolete commented out code. Then I have some questions about the following components/pages:
- components/reports/DistributionChart.vue: is this a work in progress related to @jasetran's enhancement request? I didn't see it being imported or used anywhere, but maybe I missed it.
- components/reports/IndividualScoreReportTask.vue and pages/IndividualReport.vue: How much of the report names, descriptions, colors, etc. can we (or should we) move into the helpers/reports.js. My preference is to have as much of that centralized as makes sense. Likewise, how much of the PDF conversion code can be put in a common file and then imported into both the score report and individual score report pages?
richford
approved these changes
Mar 7, 2024
|
On the road to ROAR at home... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.