Update to Dipy 1.2.0 #384
Merged
Update to Dipy 1.2.0 #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36000
force-pushed
the
avoid_dipy_load_tractogram_bug
branch
from
d942d41
to
d65354d
Compare
|
Fixes #263 |
36000
force-pushed
the
avoid_dipy_load_tractogram_bug
branch
2 times, most recently
from
22fbc9e
to
4db8232
Compare
36000
force-pushed
the
avoid_dipy_load_tractogram_bug
branch
from
53ef6c3
to
113af2d
Compare
This was referenced Sep 3, 2020
|
Heads up that DIPY 1.2 is due to be released any day now. We can probably require that as a dependency and then merge this PR? |
36000
force-pushed
the
avoid_dipy_load_tractogram_bug
branch
from
1bc49c8
to
ff9fa79
Compare
36000
changed the title
arokem
reviewed
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The load_tractogram in dipy v1.1.1 uses srow to get the affine information from a reference. However, some files have affine stored in the q info (q offset, pixdim), not s. This is fixed in the current dipy master, where they find the best source for affine information, but not dipy 1.1.1 .
Until a new version of dipy is released, we can use this PR with some datasets. This PR will probably not need to be merged, especially if a new version of dipy is releasing soon.