test: hardhat compatibility #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banteg
force-pushed
the
fix/hardhat-chain-id
branch
from
54db2cc to
ed027fa
Compare
fubuloubu
approved these changes
Apr 7, 2021
|
Don't merge yet, there are a few more fixes coming. |
fubuloubu
approved these changes
Apr 12, 2021
|
I don't know why I approved this twice lol |
|
All tests pass with |
fubuloubu
approved these changes
Apr 19, 2021
|
Approved a third time for the charm |
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Aug 8, 2021
* test: hardhat compatibility * test: fix for hardhat timestamp drift
sambacha
pushed a commit
to sambacha/yearn-vaults
that referenced
this pull request
Sep 7, 2021
* test: hardhat compatibility * test: fix for hardhat timestamp drift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a fix for mismatching
chain.idandchainid()(1337 vs 1) in ganache, but hardhat doesn't have this problem (both are 31337). This change only applies the fix for ganache. This only affectspermittests.