feat: Remove saving arguments to a file when running sim bot #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
With
Brownie >= 1.17.0, we can pass extra arguments to thebrownie run ...(eth-brownie/brownie#1259).This makes it unnecessary to pass extra arguments to
brownie run ...in files.This should allow for better concurrent use of the simulation bot
Testing Plan
Run
bash bot/launch_simulator.sh -a 0x036099f243E135cf2ADF449C2dD5497Da20FB82D -i 2141984556locallyLaunch the sim poller (
python bot/bot_poller.py), and execute the following command in telegram:/sim 0x036099f243E135cf2ADF449C2dD5497Da20FB82D/sim 0x7900c70a377f89DF29D1D1939469ae3B74c5B740