Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardhat): Update contracts and add ghost interaction script #789

Conversation

mpaya5
Copy link
Contributor

@mpaya5 mpaya5 commented Jan 3, 2025

Fixes #786

What

  • Updated contracts in genlayer-studio to match the latest changes from the main branch of the consensus repository.
  • Adjusted tests to align with the updated contract functionality.
  • Updated consensus-flow.js script to handle new contract methods and functionality.
  • Added ghost-call-flow.js script to:
    • Deploy ghost contracts.
    • Implement ghost contract transaction flows.
    • Enable generation of transactions to the node via ghost contracts.

Why

  • To ensure consistency between the deployed contracts in the consensus repository and the genlayer-studio development environment.
  • To prevent potential issues arising from mismatched contract versions.
  • To support new features and functionality introduced in the consensus repository.

Testing done

  • Verified that updated contracts deploy correctly in the Hardhat node.
  • Tested new functionality in the consensus-flow.js script.
  • Ran end-to-end tests using the ghost-call-flow.js script to confirm correct deployment and transaction flow.
  • Ensured all pre-existing tests pass with the updated contracts.

Decisions made

  • Prioritized alignment with the consensus repository's main branch to maintain development consistency.
  • Focused on creating a modular ghost-call-flow.js script for future extensibility.

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

  • Review the updated contracts to ensure they match the latest version from the consensus repository.
  • Check the consensus-flow.js script for correct handling of new contract methods.
  • Verify that the ghost-call-flow.js script correctly deploys and interacts with ghost contracts.
  • Test both scripts for integration with the updated Hardhat node.

User facing release notes

This update aligns the genlayer-studio project with the latest contracts from the consensus repository. Key changes include:

  • Updated contracts deployed to the Hardhat node.
  • Enhanced consensus-flow.js script for new contract functionality.
  • Added ghost-call-flow.js script for deploying and interacting with ghost contracts.
    These improvements ensure consistency, support new features, and maintain a seamless development and testing environment.

- Update contracts to match consensus repository
- Adjust tests according to new contract changes
- Update consensus-flow.js script to handle new contract functionality
- Add ghost-call-flow.js script to deploy and interact with ghost contracts
@mpaya5 mpaya5 self-assigned this Jan 3, 2025
@mpaya5 mpaya5 added enhancement New feature or request run-tests labels Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.79%. Comparing base (e7baf02) to head (845a30c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   16.79%   16.79%           
=======================================
  Files         124      124           
  Lines        9856     9856           
  Branches      248      248           
=======================================
  Hits         1655     1655           
  Misses       8116     8116           
  Partials       85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mpaya5 and others added 5 commits January 7, 2025 09:01
…sensus-repository-to-hardhat-node-in-genlayer-studio
…sensus-repository-to-hardhat-node-in-genlayer-studio
…sitory-to-hardhat-node-in-genlayer-studio' of github.com:yeagerai/genlayer-studio into feat/hardhat-sync-updated-contracts-from-consensus-repository-to-hardhat-node-in-genlayer-studio
…sensus-repository-to-hardhat-node-in-genlayer-studio
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cristiam86 cristiam86 merged commit e640dd2 into main Jan 21, 2025
15 of 16 checks passed
Copy link
Contributor

🎉 This PR is included in version 0.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(hardhat): Sync Updated Contracts from Consensus Repository to Hardhat Node in Genlayer-Studio
2 participants