Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve logging system in terminal and UI #540
feat: improve logging system in terminal and UI #540
Changes from 113 commits
7fb3269
b7df785
7309d9a
b973d5b
1931392
1881868
8745104
95ff7cd
13fb239
d8def67
537874b
2aa6a6b
f7eefe2
477b276
f97cae3
914e0b3
b156acc
ca673fd
3efe889
4d631fb
865fa59
21e979f
78d7788
f63a58b
80bd814
2cae2ee
e21bae3
c273489
4345a92
5839ade
0878fc2
eb9067b
df4c5b6
af1d3c2
df57923
b98af12
0d053df
cb2eae5
a3cf563
8893e30
7b10c0e
ba933c9
4f7ef93
bba659d
f0a502a
c433b68
78d1e46
21d774d
7c62bd4
78bbc6f
0fe421a
cdbbda7
321cca8
d0f1bf1
fa2d509
3b1f100
9506023
d72826c
68ae363
639ccf0
a011123
7f01289
9eaf354
2612a2d
df6aa12
d654582
7ee51fa
335d1c0
45c3872
289c5b9
f647feb
ae9d371
60a8a50
7bc6ab6
91cc92a
6459efd
d509351
2f0d182
57ed997
0ffce0b
19b872e
4d33f69
cdd3ab9
5ac3453
ebb8319
6152700
812a680
ab7bcc5
0cc1dd2
50877f4
945c71a
2510755
7468c44
28bfcba
055f216
c2d20d5
728b6f1
2712a5b
66fc1b7
65f216a
c06380c
3f91465
5519fc4
803ca3e
0650e1c
d35fc74
147a1bc
23de0b7
a4ff542
d66fd15
2232cb2
79fbd74
dbc7754
9119094
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason behind this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was redundant because we also update the status in the update status method, and I thought it was causing the unit test to fail. But actually updating the mocking in the test was enough, so I'm reverting this! nevermind