Show exact tag for commit on diff view (go-gitea#11846)

* Show exact tag for commit on diff view * Fix comment Co-authored-by: techknowlogick <[email protected]>
ydelafollye · Jul 31, 2020 · a8bf66c · a8bf66c
1 parent 4ee891b
commit a8bf66c
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/modules/git/commit.go b/modules/git/commit.go
@@ -466,7 +466,7 @@ func (c *Commit) GetSubModule(entryname string) (*SubModule, error) {
 	return nil, nil
 }
 
-// GetBranchName gets the closes branch name (as returned by 'git name-rev --name-only')
+// GetBranchName gets the closest branch name (as returned by 'git name-rev --name-only')
 func (c *Commit) GetBranchName() (string, error) {
 	data, err := NewCommand("name-rev", "--exclude", "refs/tags/*", "--name-only", "--no-undefined", c.ID.String()).RunInDir(c.repo.Path)
 	if err != nil {
@@ -482,6 +482,21 @@ func (c *Commit) GetBranchName() (string, error) {
 	return strings.SplitN(strings.TrimSpace(data), "~", 2)[0], nil
 }
 
+// GetTagName gets the current tag name for given commit
+func (c *Commit) GetTagName() (string, error) {
+	data, err := NewCommand("describe", "--exact-match", "--tags", c.ID.String()).RunInDir(c.repo.Path)
+	if err != nil {
+		// handle special case where there is no tag for this commit
+		if strings.Contains(err.Error(), "no tag exactly matches") {
+			return "", nil
+		}
+
+		return "", err
+	}
+
+	return strings.TrimSpace(data), nil
+}
+
 // CommitFileStatus represents status of files in a commit.
 type CommitFileStatus struct {
 	Added    []string

diff --git a/routers/repo/commit.go b/routers/repo/commit.go
@@ -311,6 +311,12 @@ func Diff(ctx *context.Context) {
 		ctx.ServerError("commit.GetBranchName", err)
 		return
 	}
+
+	ctx.Data["TagName"], err = commit.GetTagName()
+	if err != nil {
+		ctx.ServerError("commit.GetTagName", err)
+		return
+	}
 	ctx.HTML(200, tplCommitPage)
 }
 

diff --git a/templates/repo/commit_page.tmpl b/templates/repo/commit_page.tmpl
@@ -30,6 +30,9 @@
 			{{if .BranchName}}
 				<span class="text grey">{{svg "octicon-git-branch" 16}}{{.BranchName}}</span>
 			{{end}}
+			{{if .TagName}}
+				<span class="text grey">{{svg "octicon-tag" 16}}{{.TagName}}</span>
+			{{end}}
 		</div>
 		<div class="ui attached info segment {{$class}}">
 			<div class="ui stackable grid">