Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユーザーカードコンポーネントの作成 #18

Merged
merged 8 commits into from
Feb 17, 2024

Conversation

N-ha-1050
Copy link
Contributor

概要

関連するIssue

やったこと

  • shadcn-ui から Card の追加
  • Props の取得
  • 画像、xid、nickname の配置
  • xへのリンクの追加

できなかったこと

  • xidからのプロフィールアイコンの取得
  • チェックマークのデザイン
  • storybook のエラー対応 (Link が使えていないみたいです)
  • storybook でのstate管理
  • 高さと幅の詳細設計(現状は、 w-72 h-20 を指定し、テキストオーバーフローには truncate で対応)

レビュー観点

@N-ha-1050 N-ha-1050 requested a review from nyatinte February 17, 2024 01:50
@N-ha-1050 N-ha-1050 marked this pull request as ready for review February 17, 2024 02:36
@nyatinte nyatinte force-pushed the feat/create-user-card-component branch from f4b0d57 to 1b52144 Compare February 17, 2024 03:23
@nyatinte nyatinte merged commit 3738831 into develop Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants