Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silence -Wformat warning #482

Merged
merged 2 commits into from
Aug 8, 2024
Merged

silence -Wformat warning #482

merged 2 commits into from
Aug 8, 2024

Conversation

JanMarvin
Copy link
Collaborator

CRAN has a few warnings currently only visible with older clang on Mac. -Wformat on gcc and clang on Linux does not complain.

read_workbook.cpp:555:52: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
read_workbook.cpp:565:54: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
read_workbook.cpp:626:50: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]

@JanMarvin
Copy link
Collaborator Author

Cannot reproduce on Mac either. Maybe a spurious warning in clang14?

using C++ compiler: ‘Apple clang version 15.0.0 (clang-1500.3.9.4)’
using SDK: ‘MacOSX14.4.sdk’

JanMarvin
JanMarvin commented Aug 8, 2024
View reviewed changes
src/read_workbook.cpp Outdated Show resolved Hide resolved
@JanMarvin JanMarvin merged commit d0c1bb9 into master Aug 8, 2024
9 of 10 checks passed
@JanMarvin JanMarvin deleted the snprintf_fix branch August 8, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JanMarvin