Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rdevel segfaults2 #473

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Fix rdevel segfaults2 #473

merged 3 commits into from
Jun 3, 2024

Conversation

JanMarvin
Copy link
Collaborator

Hi @ycphs , your merge was a little to quick for me :)

I wanted to at least make the CI pass. There are a bunch of lintr and remaining other issues that I wont tackle. I was just curious to see if the segfault can be fixed and doing my part to keep the package on CRAN.

Fingers crossed that it will build now run without errors.

@JanMarvin
Copy link
Collaborator Author

Alright R-CMD-check run was a success! Adding curl as a dependency for three occurrences of a testthat function might be something to consider.

  1. You might want to have a second look at my update of the github actions script in the previous commit. After a short night and a long day, I was losing it a bit and simply replaced everything with the current example (similar for this commit, but ...).

  2. A long time ago, I started to merge a few commits into the development branch. Maybe if you go over the package the next time, you can resurrect a few.

@ycphs ycphs merged commit 6b0cf0f into master Jun 3, 2024
8 of 10 checks passed
@JanMarvin JanMarvin deleted the fix_rdevel_segfaults2 branch June 4, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants