Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Update ycmd submodule #3928

Merged
merged 1 commit into from
Aug 5, 2021
Merged

[READY] Update ycmd submodule #3928

merged 1 commit into from
Aug 5, 2021

Conversation

bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Aug 5, 2021

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

[Please explain in detail why the changes in this PR are needed.]

Mostly a bugfix update:

  • Upgrade tsserver to 4.3.5 and fix the path issue on Windows
  • Upgrade rust-analyzer to nightly-2021-07-29 and make sure proc macros
    work

This change is Reviewable

Mostly a bugfix update:

- Upgrade tsserver to 4.3.5 and fix the path issue on Windows
- Upgrade rust-analyzer to nightly-2021-07-29 and make sure proc macros
  work
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #3928 (d0bf908) into master (8c6081c) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3928      +/-   ##
==========================================
+ Coverage   91.76%   91.90%   +0.13%     
==========================================
  Files          27       27              
  Lines        3668     3668              
==========================================
+ Hits         3366     3371       +5     
+ Misses        302      297       -5     

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Thanks.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)

@puremourning puremourning added the Ship It! Manual override to merge a PR by maintainer label Aug 5, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 5, 2021

Thanks for sending a PR!

@mergify mergify bot merged commit 518275b into ycm-core:master Aug 5, 2021
@bstaletic bstaletic deleted the ycmdup branch August 6, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It! Manual override to merge a PR by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants