Skip to content

Commit

Permalink
fix(prettier): remove prettier from peer-deps (#686)
Browse files Browse the repository at this point in the history
Why?
----

The `prettier` package is required by the `eslint-prettier-plugin` package.
So, this `eslint-config-ybiquitous` package does not need to require it as a peer dependency.
  • Loading branch information
ybiquitous authored Jul 4, 2020
1 parent 6214d93 commit f35e155
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion goodcheck.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
rules:
- id: update-peer-dependencies
pattern:
regexp: '"(eslint|prettier|@typescript-eslint/.+)": "[0-9.^~]+"'
regexp: '"(eslint|@typescript-eslint/.+)": "[0-9.^~]+"'
glob: package.json
message: Don't forget updating `peerDependencies` when updating `devDependencies`.
justification:
Expand Down
6 changes: 1 addition & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@
"peerDependencies": {
"@typescript-eslint/eslint-plugin": ">=2.34.0 <3",
"@typescript-eslint/parser": ">=2.34.0 <3",
"eslint": ">=6.8.0 <7",
"prettier": ">=1.19.1 <3"
"eslint": ">=6.8.0 <7"
},
"peerDependenciesMeta": {
"@typescript-eslint/eslint-plugin": {
Expand All @@ -59,9 +58,6 @@
},
"eslint": {
"optional": false
},
"prettier": {
"optional": false
}
},
"scripts": {
Expand Down

0 comments on commit f35e155

Please sign in to comment.