-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade core octane #682
Merged
Merged
Upgrade core octane #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtgraham
approved these changes
Mar 2, 2020
packages/core/addon/components/navi-visualization-config/goal-gauge.js
Outdated
Show resolved
Hide resolved
packages/core/addon/components/navi-visualization-config/pie-chart.js
Outdated
Show resolved
Hide resolved
packages/core/addon/components/navi-visualization-config/table.js
Outdated
Show resolved
Hide resolved
packages/core/addon/components/navi-visualizations/goal-gauge.js
Outdated
Show resolved
Hide resolved
jkusa
reviewed
Mar 5, 2020
packages/core/addon/components/navi-visualization-config/goal-gauge.js
Outdated
Show resolved
Hide resolved
packages/core/addon/components/navi-visualization-config/line-chart.js
Outdated
Show resolved
Hide resolved
packages/core/addon/components/navi-visualization-config/line-chart.js
Outdated
Show resolved
Hide resolved
packages/core/addon/components/navi-visualization-config/series-chart.js
Outdated
Show resolved
Hide resolved
packages/core/addon/components/navi-visualization-config/series-chart.js
Outdated
Show resolved
Hide resolved
@@ -1,2 +0,0 @@ | |||
{{!-- Copyright 2019, Yahoo Holdings Inc. Licensed under the terms of the MIT license. See accompanying LICENSE.md file for terms. --}} | |||
{{yield _editableSelection this}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow
packages/core/addon/templates/components/power-select-search.hbs
Outdated
Show resolved
Hide resolved
Remove a lot of ember get Co-Authored-By: Jon Kilroy <[email protected]>
Co-Authored-By: Jon Kilroy <[email protected]>
jkusa
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #604
Description
Upgrades core to octane
License
I confirm that this contribution is made under an MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.