-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new_mask_function #383
new_mask_function #383
Conversation
@lilymaryam The build is failing (https://github.com/yatisht/usher/actions/runs/11690922774/job/33063972836?pr=383#step:3:3210). Could you please review? |
Hi Yatish, I am trying to figure this out now. Sorry about that. I'll update soon. |
@lilymaryam It passed the tests this time. If you're happy with this version, I'll go ahead and merge. |
Hi Yatish! I think I figured out the build error. I'm going to close the pull request and open a new one. |
Hi Yatish! I didn't realize that repo changes would be immediately reflected in my current pull request. I closed this one and opened a new one which is identical to this one. I can reopen this one if you prefer but the new one should also build without error. This current version is my most up to date. I will likely come back in a few weeks to improve efficiency where I can. |
I merged the other one. |
Thank you! |
Added -D and -f to matUtils mask for post-placement local masking. To be further detailed in MTB manuscript.