Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_mask_function #383

Closed
wants to merge 20 commits into from
Closed

new_mask_function #383

wants to merge 20 commits into from

Conversation

lilymaryam
Copy link
Contributor

Added -D and -f to matUtils mask for post-placement local masking. To be further detailed in MTB manuscript.

@yatisht
Copy link
Owner

yatisht commented Nov 16, 2024

@lilymaryam
Copy link
Contributor Author

Hi Yatish, I am trying to figure this out now. Sorry about that. I'll update soon.

@yatisht
Copy link
Owner

yatisht commented Nov 19, 2024

@lilymaryam It passed the tests this time. If you're happy with this version, I'll go ahead and merge.

@lilymaryam
Copy link
Contributor Author

Hi Yatish! I think I figured out the build error. I'm going to close the pull request and open a new one.

@lilymaryam lilymaryam closed this Nov 19, 2024
@lilymaryam
Copy link
Contributor Author

lilymaryam commented Nov 19, 2024

Hi Yatish! I didn't realize that repo changes would be immediately reflected in my current pull request. I closed this one and opened a new one which is identical to this one. I can reopen this one if you prefer but the new one should also build without error. This current version is my most up to date. I will likely come back in a few weeks to improve efficiency where I can.

@yatisht
Copy link
Owner

yatisht commented Nov 19, 2024

I merged the other one.

@lilymaryam
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants