faster Ripples #202
Merged
faster Ripples #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now takes 1 instead of 4 hours on the May 25 tree. It can still be faster, and more testing on other trees is needed.
Other than the is_sibling columns, the output match. I feel these columns are not set in the original ripples if the node is not optimal. (The only update to node_has_unique is at lines 165-195 in usher_mapper.cpp ) This version update it for all the node (correctly, because donor/acceptor parsimony score columns match, and usher_mapper.cpp:503 will artificially increase the parsimony score if it is placed as children).