GuidedProposal: internal settings to be used by Agama #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Internal Jenkins job #1151 failed |
|
✔️ Internal Jenkins job #1152 successfully finished |
ancorgs
added a commit
to agama-project/agama
that referenced
this pull request
Mar 22, 2024
…ust_by_ram (#1111) ## Problem In Agama a volume can have automatic sizes based on one or several of the following reasons: - Snapshots - Fallbacks from other volumes (eg. "/" max size can exist or not based on the existence of "/home") - Size of the RAM But the third one was not working because it was impossible to set the sizes manually for volumes with the property `adjust_by_ram` in their corresponding outline. ## Solution This sets the new YaST setting `ignore_adjust_by_ram` if the user has decided to manually enforce sizes. So now it's possible to honor the automatic size or to use custom sizes instead. Using the automatic size | The table | The form | |-|-| |  |  | Forcing manual sizes | The table | The form | |-|-| |  |  | To get some background on how this functionality compares to the traditional YaST checkbox "Enlarge to RAM Size for Suspend", see the dedicated section at the description of #1081. Additionally, this pull request enables `adjust_by_ram` for swap at the Tumbleweed product, to raise awareness and get feedback. ## Testing - Added a new unit test - Tested manually (see screenshots above) ## Dependencies Needs yast/yast-storage-ng#1376 at yast2-storage-ng, which implies the corresponding rpm dependency has been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We wanted to add the following two functionalities to Agama:
Solution
This adds two new settings to
ProposalSettingsandVolumeSpecificationto make all that possible.None of the changes affect YaST or AutoYaST for now.
Testing
Other pull requests
See agama-project/agama#1111 as an example on how Agama relies on this.