Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brokenmodules #1127

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix brokenmodules #1127

merged 2 commits into from
Oct 23, 2024

Conversation

jreidinger
Copy link
Member

Problem

When there are multiple blacklisted modules then parsing does not work correctly and add it as single entry.

trello: https://trello.com/c/YrsSjjRG/3860-1231313-brokenmodulesab-results-in-invalid-blacklist
bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1231313

Solution

Make parsing more robust regarding spaces around comma.

Testing

  • Added a new unit test

@coveralls
Copy link

Coverage Status

coverage: 40.922%. remained the same
when pulling de0e131 on fix_brokenmodules
into c277f63 on SLE-15-SP7.

@jreidinger jreidinger merged commit e6ebc98 into SLE-15-SP7 Oct 23, 2024
12 checks passed
@jreidinger jreidinger deleted the fix_brokenmodules branch October 23, 2024 11:48
@yast-bot
Copy link
Contributor

❌ Internal Jenkins job #3 failed

@jreidinger jreidinger mentioned this pull request Oct 23, 2024
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #4 successfully finished
✔️ Created IBS submit request #349415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants