-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write cio_ignore kernel arguments always #1104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Jan 24, 2024
teclator
force-pushed
the
cio_ignore_always
branch
5 times, most recently
from
January 25, 2024 10:04
85181dd
to
20b9098
Compare
teclator
force-pushed
the
cio_ignore_always
branch
from
January 25, 2024 10:06
20b9098
to
6816639
Compare
teclator
force-pushed
the
cio_ignore_always
branch
from
January 25, 2024 11:31
8ff0f2e
to
1b0390b
Compare
jreidinger
reviewed
Jan 25, 2024
jreidinger
reviewed
Jan 25, 2024
Changes based on CR
teclator
force-pushed
the
cio_ignore_always
branch
from
January 25, 2024 12:27
af85a28
to
98b1343
Compare
jreidinger
approved these changes
Jan 25, 2024
✔️ Internal Jenkins job #152 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When installing an s390x machine it is not writing the cio_ignore kernel command line parameter which is given through the parmfile.
Solution
In zVM machines it does not write the cio_settings at all because it was requested (fate#317861), but as the bug already reports, if the cio_ignore parameter is given through the parmfile we should kept it as it was given and if not we should call
cio_ignore -k
to obtain the kernel command line arguments to be used.It depends in a change in the kernel because it was using the /etc/install.inf file for checking if there is some cmdline argument which is wrong in agama because there is no linuxrc at all.
And looks like the Bootloader kernel arguments are not read when the configuration is proposed at all mainly because the parameter is not whitelisted (so, it also depends on yast/yast-bootloader#693)
Testing