Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write cio_ignore kernel arguments always #1104

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Write cio_ignore kernel arguments always #1104

merged 5 commits into from
Jan 25, 2024

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Jan 24, 2024

Problem

When installing an s390x machine it is not writing the cio_ignore kernel command line parameter which is given through the parmfile.

Solution

In zVM machines it does not write the cio_settings at all because it was requested (fate#317861), but as the bug already reports, if the cio_ignore parameter is given through the parmfile we should kept it as it was given and if not we should call cio_ignore -k to obtain the kernel command line arguments to be used.

It depends in a change in the kernel because it was using the /etc/install.inf file for checking if there is some cmdline argument which is wrong in agama because there is no linuxrc at all.

And looks like the Bootloader kernel arguments are not read when the configuration is proposed at all mainly because the parameter is not whitelisted (so, it also depends on yast/yast-bootloader#693)

Testing

  • Tested manually

@teclator teclator force-pushed the cio_ignore_always branch 5 times, most recently from 85181dd to 20b9098 Compare January 25, 2024 10:04
@coveralls
Copy link

coveralls commented Jan 25, 2024

Coverage Status

coverage: 41.058% (-0.006%) from 41.064%
when pulling 8ff0f2e on cio_ignore_always
into 25e6ff5 on master.

@teclator teclator merged commit 94b7d84 into master Jan 25, 2024
6 of 10 checks passed
@teclator teclator deleted the cio_ignore_always branch January 25, 2024 14:46
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #152 successfully finished
✔️ Created OBS submit request #1141535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants