Merge pull request #1099 from yast/sp6_fix_old_repo_refresh

[SLE15-SP6] Refresh repositories with changed URL and reload them again
yast · Oct 31, 2023 · 01c2af1 · 01c2af1
2 parents 7b057a9 + d856536
commit 01c2af1
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 1 deletion.
diff --git a/package/yast2-installation.changes b/package/yast2-installation.changes
@@ -1,3 +1,10 @@
+-------------------------------------------------------------------
+Tue Oct 31 08:29:48 UTC 2023 - Ladislav Slezák <[email protected]>
+
+- Refresh repositories with changed URL and reload them again
+  to activate the changes (related to bsc#1215884)
+- 4.6.8
+
 -------------------------------------------------------------------
 Tue Aug 15 08:42:50 UTC 2023 - Stefan Hundhammer <[email protected]>
 

diff --git a/package/yast2-installation.spec b/package/yast2-installation.spec
@@ -16,7 +16,7 @@
 #
 
 Name:           yast2-installation
-Version:        4.6.7
+Version:        4.6.8
 Release:        0
 Summary:        YaST2 - Installation Parts
 License:        GPL-2.0-only

diff --git a/src/lib/installation/clients/inst_upgrade_urls.rb b/src/lib/installation/clients/inst_upgrade_urls.rb
@@ -19,6 +19,7 @@
 
 require "yast"
 require "installation/upgrade_repo_manager"
+require "y2packager/medium_type"
 require "y2packager/repository"
 
 Yast.import "GetInstArgs"
@@ -297,6 +298,9 @@ def save_pkg_mgr
       # do not save the changes in the test mode
       Pkg.SourceSaveAll unless test?
 
+      # reload repositories only when using the openSUSE Leap media
+      Pkg.SourceLoad if Y2Packager::MediumType.standard?
+
       # clear the old repositories
       Y2Packager::OriginalRepositorySetup.instance.repositories.clear
     end

diff --git a/src/lib/installation/upgrade_repo_manager.rb b/src/lib/installation/upgrade_repo_manager.rb
@@ -125,6 +125,12 @@ def activate_changes
       update_urls
       process_repos
       remove_services
+
+      # reload the package manager to activate the changes
+      Yast::Pkg.SourceSaveAll
+      Yast::Pkg.SourceFinishAll
+      Yast::Pkg.SourceRestore
+      Yast::Pkg.SourceLoad
     end
 
   private
@@ -167,6 +173,9 @@ def process_repos
     def update_urls
       new_urls.each do |repo, url|
         repo.url = url
+
+        # if the repository will be enabled refresh the content
+        Yast::Pkg.SourceForceRefreshNow(repo.repo_id) if status_map[repo] == :enabled
       end
     end
 

diff --git a/test/lib/clients/inst_upgrade_urls_test.rb b/test/lib/clients/inst_upgrade_urls_test.rb
@@ -36,6 +36,8 @@
     allow(Yast::UI).to receive(:QueryWidget)
     allow(Yast::UI).to receive(:ChangeWidget)
     allow(Yast::Pkg).to receive(:SourceSaveAll)
+    allow(Y2Packager::MediumType).to receive(:standard?).and_return(true)
+    allow(Yast::Pkg).to receive(:SourceLoad)
   end
 
   describe "#main" do

diff --git a/test/lib/upgrade_repo_manager_test.rb b/test/lib/upgrade_repo_manager_test.rb
@@ -97,6 +97,10 @@ def self.is_registered?
       allow(repo1).to receive(:disable!)
       allow(repo1).to receive(:delete!)
       allow(Yast::Pkg).to receive(:ServiceDelete)
+      allow(Yast::Pkg).to receive(:SourceSaveAll)
+      allow(Yast::Pkg).to receive(:SourceFinishAll)
+      allow(Yast::Pkg).to receive(:SourceRestore)
+      allow(Yast::Pkg).to receive(:SourceLoad)
     end
 
     it "removes the selected repositories" do