Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made default parameter values public #37

Merged
merged 1 commit into from
Sep 23, 2017
Merged

Made default parameter values public #37

merged 1 commit into from
Sep 23, 2017

Conversation

pefaymon
Copy link
Contributor

Swift 4 compatibility

@codecov
Copy link

codecov bot commented Sep 21, 2017

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files          11       11           
  Lines        1145     1145           
=======================================
  Hits         1056     1056           
  Misses         89       89
Impacted Files Coverage Δ
Sources/CSVReader.swift 88.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f534685...c318c84. Read the comment docs.

yaslab
yaslab approved these changes Sep 23, 2017
View reviewed changes
Copy link
Owner

@yaslab yaslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pefaymon Thank you!

@yaslab yaslab merged commit a3e7709 into yaslab:master Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaslab yaslab yaslab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pefaymon @yaslab