Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Datastore):Properly remove redundant keys from request options #4

Merged
merged 2 commits into from
May 7, 2024

Conversation

yash30201
Copy link
Owner

No description provided.

@yash30201 yash30201 force-pushed the datastore-tryout-1 branch from 84a4411 to 858c087 Compare May 7, 2024 06:38
@yash30201 yash30201 changed the title chore(Core, Spanner): Add removeObsoleteArgs helper method and use in Spanner fix(Spanner):Pproperly remove redundant keys from request options May 7, 2024
@yash30201 yash30201 changed the title fix(Spanner):Pproperly remove redundant keys from request options fix(Spanner):Properly remove redundant keys from request options May 7, 2024
Copy link

@saranshdhingra saranshdhingra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small nits.

Datastore/src/Operation.php Show resolved Hide resolved
Datastore/src/Operation.php Show resolved Hide resolved
@yash30201 yash30201 changed the title fix(Spanner):Properly remove redundant keys from request options fix(Datastore):Properly remove redundant keys from request options May 7, 2024
@yash30201 yash30201 merged commit c6275bd into datastore-php-v2 May 7, 2024
15 of 16 checks passed
@yash30201 yash30201 deleted the datastore-tryout-1 branch May 7, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants