-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Click Trigger #6
base: master
Are you sure you want to change the base?
Conversation
Hi @justingshreve, thanks for your contribution. Before I merge it in, could you add an example to the demo for click-to-show? |
Added ability to trigger hovercard via click, instead of just mouseenter...
Still defaults to mouseenter, unless attr.trigger = click exists.
Had to change some stuff in your tests too, to get them to pass. Couldn't get them to pass even when I pulled down fresh.
There are a lot of commits, but changes are minor. Played around with some stuff in various commits.