-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fallback to npm config if it exists after getting default yarn config value #871
Conversation
Is there a way to tell when this has been released? |
|
||
// if we have no yarn option for this or have used a default then use the npm | ||
// value if it exists | ||
if (!val || val === DEFAULTS[key]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this code, if the value is the same as the default, it will favor the npm config even if the user explicitly set it. Shouldn't an explicit setting still take precedence over the npm config value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we might want to check if it's undefined
instead of just falsy, since the user could also explicitly specify a falsy value.
I'm afraid it's still not working - I'm trying to install a scoped package with a scope registered in my global |
@evil-shrike That issue was closed. Can you provide a more detailed example? Maybe it is a different issue. |
I was using
So, now, where do I put my config if Yarn doesn't read from |
@kittens any update on this? Seems logical to read configs from |
also curious when the version with this fix (looks to be 0.24.2) will get released / published to NPM? |
Is there any update when this fix will get rolled out? I can still find the issue with |
I've got 0.24.5, this issue seem to persist. |
@bchoddny @sarbbottam have a look if you have this issue with the fallback: #3920 |
I'm experiencing this in 1.3.2
|
I'm trying to add a package from a scoped registry that asks for password, username and email. I am able to do this using NPM by setting this up to While searching for solution, I've found issue #606 and also this issue from 2016. If so, could anyone tell me if this is working and what is the right semantic? This is what I've added to registry "https://registry.yarnpkg.com"
"@company:registry" "http://company.domain.com/artifactory/api/npm/packages/"
"//company.domain.com/artifactory/api/npm/packages/:_password" "passwordHASH"
"//company.domain.com/artifactory/api/npm/packages/:username" "me"
"//company.domain.com/artifactory/api/npm/packages/:email" "[email protected]"
"//company.domain.com/artifactory/api/npm/packages/:always-auth" "true" It understand the scoped registry but it fails to download the package due to not finding any credentials. I also have a working
|
We tried putting the following in |
No description provided.