Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package,yarn): remove eslint-plugin-flow-vars #622

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

mrtnbroder
Copy link
Contributor

@mrtnbroder mrtnbroder commented Oct 11, 2016

eslint-plugin-flow-vars is deprecated and has been merged into eslint-plugin-flowtype.

@sebmck
Copy link
Contributor

sebmck commented Oct 11, 2016

Can you double check that we aren't still referencing this from inside of the eslint config in package.json?

@mrtnbroder
Copy link
Contributor Author

mrtnbroder commented Oct 11, 2016

It's still a dependency of your personal eslint-config @kittens, https://github.com/kittens/eslint-config-kittens/blob/master/package.json#L19

Other than that, I'm not sure what you mean by "inside of the eslint config in package.json"?

@pluma
Copy link

pluma commented Oct 11, 2016

@mrtnbroder I think Seb means this: https://github.com/yarnpkg/yarn/blob/master/package.json#L99

I.e. make sure the config doesn't rely on flow-vars.

@hzoo
Copy link
Contributor

hzoo commented Oct 11, 2016

@cpojer
Copy link
Contributor

cpojer commented Oct 12, 2016

would you mind rebasing this?

@cpojer cpojer self-assigned this Oct 12, 2016
eslint-plugin-flow-vars is deprecated and has been merged into eslint-plugin-flowtype.
@mrtnbroder
Copy link
Contributor Author

Done, @cpojer !

@sebmck
Copy link
Contributor

sebmck commented Oct 12, 2016

Thank you @mrtnbroder!

@sebmck sebmck merged commit b1a0656 into yarnpkg:master Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants