Fix yarn create command on Windows
#3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Jul 7, 2017
src/cli/commands/create.js
Outdated
| @@ -51,7 +52,10 @@ export async function run(config: Config, reporter: Reporter, flags: Object, arg | |||
| throw new MessageError(reporter.lang('createInvalidBin', packageName)); | |||
| } | |||
|
|
|||
| await child.spawn(binPath, rest, {stdio: `inherit`}); | |||
| const linkedBinPath = config.getTemp(`create-bin-${packageName}`); | |||
| await linkBin(binPath, linkedBinPath); | |||
There was a problem hiding this comment.
I'm not sure calling linkBin is required, is it? It should have been done when adding the package (l30)
There was a problem hiding this comment.
I assumed we were previously not using the already linked bin for a reason. If there are no reasons, I can indeed change to use the existing one in global.
There was a problem hiding this comment.
Nope, no particular reason - I just forgot about this behavior when I implemented the feature 😞
There was a problem hiding this comment.
@arcanis Please review the new implementation. Tested on Windows.
Also I wonder, shouldn't we pass the flags to runGlobal (and now also to getBinFolder)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Yarn create fails on Windows, see #3530
The issue is caused by Yarn trying to run a javascript file as an executable (the !# doesn't work in Windows command)
This PR uses the existing
linkBinfunction to create any appropriate shim depending on the system.Test plan
No existing test. Manually tested on Windows 10 and one linux. More tests by other people would be appreciated.
Also any idea to automate a test here is welcomed.