fixes transtive file: dependencies #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestander
commented
Jun 23, 2017
| }, | ||
| "devDependencies": { | ||
| "b": "file:b" | ||
| "b": "file:./b" |
There was a problem hiding this comment.
Without this fix the test was failing.
That is strange and needs a bit more investigation later on
bestander
commented
Jun 23, 2017
| @@ -107,7 +107,7 @@ export default class FileResolver extends ExoticResolver { | |||
| if (temp === section) { | |||
| temp = Object.assign({}, section); | |||
| } | |||
| temp[k] = `file:${path.relative(this.config.cwd, path.join(loc, util.removePrefix(v, 'file:')))}`; | |||
| temp[k] = `file:./${path.relative(this.config.cwd, path.join(loc, util.removePrefix(v, 'file:')))}`; | |||
There was a problem hiding this comment.
An alternative would be to make the fix at fetcher level that tries to fetch non relative paths from registry.
arcanis
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Transitive file: dependencies were losing relative path indication and you could not install
root -> a-> file:./bThe problem was that between tarball-resolver and tarball-fetcher we were loosing information about file: protocol that clearly identifies that the tarball is local.
Test plan
Added test.