Use skipIntegrityCheck instead of skipIntegrity in licenses command

[voxsim]

In #3238 I noticed that we changed the skipIntegrity flag in skipIntegrityCheck (this is the commit bd8e326)

Test plan
I have no idea how to test it; right now I don't have time to see this part. Let's park here for now.

[bestander]

No need for a unit test, I think this should have been caught by Flow.

[voxsim]

I thought the same, we should thank git bisect to found the commit :D

I think I will spend some time to understand package-* and integrity-checker because IMO they require some love

[bestander]

Yeah.
I am planning to do a bit more changes to integrity-checker in the next couple of weeks.

• remove reporter.warn from it
• split check operation from reading artifacts data from .yarn-integrity
• move integrity check into an earlier phase of install command

Happy to collaborate and sync on this

[voxsim]

That sounds great :D

[voxsim]

I think to add some unit/integration testing do understand what effectively does

[voxsim]

Ah before I forget, If you want to delegate something, I am happy to collaborato too :D

[bestander]

Would you want to extract the reporter out of integrity-checker?
I think I won't be able to get down to this task before next week.

[voxsim]

Sure, I will open a pull request soon. By 'extract the reporter out of integrity-checker' do you mean remove every report.warn from integrity-checker and add a generic this.reporter.warn(this.reporter.lang('integrityFailed')); or something else?
One other guess could be extract _compareIntegrityFiles out from integrity-checker O.o but IMO does not seem a great idea

[bestander]

I think integrity-checker should not have side effects and reporting warning is one.
Separation of concerns.
We actually care about outputting warnings about what exactly failed in integrity check in check command.

Would be great if those reporter.warn could be moved to check.js command and integrity-checker would just output whether integrity matches and if not in what aspect of check has failed (e.g. FLAGS_DONT_MATCH, FILES_DONT_MATCH etc).