Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use of reporter lang method #2269

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Add use of reporter lang method #2269

merged 1 commit into from
Jan 4, 2017

Conversation

msaglietto
Copy link
Contributor

Summary
Continuing with #1387 now most of the files are cover ..
Some missing are:

https://github.com/yarnpkg/yarn/blob/master/src/lockfile/parse.js#L178 that dont have access to a reporter

https://github.com/yarnpkg/yarn/blob/master/src/cli/index.js it would be nice to translate the commander options .. but the definition of the options needs to be moved to after the reporter creation

And if there is any other translation missing let me know

Test plan

Just ran yarn run test and hope for the best

@msaglietto
Copy link
Contributor Author

It seams the test, not only take to long to run, are not reliable ...

After a few runs locally it fails on should expose npm_config_argv environment variable to lifecycle scripts for back compatibility with npm (#684) if I run yarn run test

But if I run npm run test locally it fails on install should respect --no-bin-links flag also

And now the build fail in install with arg that has install scripts ... that it seems not related to my changes

@bestander
Copy link
Member

Thanks for the PR, let's merge it, could you rebase it please?

@msaglietto
Copy link
Contributor Author

@bestander Updated ... 5 test are failing locally and 1 appveyor fail .. but the others pass .. so not sure what to trust

@bestander bestander merged commit 6656ee3 into yarnpkg:master Jan 4, 2017
@bestander
Copy link
Member

Some tests can depend on network so they might fail, if other CI are fine then it should be safe

@bestander
Copy link
Member

#2439 caused by this PR.
Probably an older bug where # is not in ...vars caused escaping of the whole string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants