Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading Scoped + Private packages fails on npm-registry (Tarball Fetcher) #1134

Closed
johndagostino opened this issue Oct 17, 2016 · 0 comments

Comments

@johndagostino
Copy link

Do you want to request a feature or report a bug?

feature

What is the current behavior?

Testing out the recently merged _authToken support. Package info is correctly downloaded.

But npm-registry.js cannot determine the correct scope when downloading a package tarball as tarball fetcher passes in the full path so getScope() fails to determine the correct scope.

This means private scoped packages get the registry url switched to the yarn mirror.

What is the expected behavior?

Tarball download respects the always-auth and _authToken configuration options when downloading packages.

Please mention your node.js, yarn and operating system version.

master branch - 8f4f01e

devongovett added a commit to devongovett/yarn that referenced this issue Oct 17, 2016
Sends the auth token for scoped packages, which may be private. Fixes yarnpkg#1134 and yarnpkg#521.
devongovett added a commit to devongovett/yarn that referenced this issue Oct 17, 2016
Sends the auth token for scoped packages, which may be private. Fixes yarnpkg#1134 and yarnpkg#521.
cpojer pushed a commit that referenced this issue Oct 17, 2016
Sends the auth token for scoped packages, which may be private. Fixes #1134 and #521.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant