Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit devDependencies from licenses #1103

Closed
remko opened this issue Oct 15, 2016 · 4 comments
Closed

Omit devDependencies from licenses #1103

remko opened this issue Oct 15, 2016 · 4 comments

Comments

@remko
Copy link

remko commented Oct 15, 2016

Do you want to request a feature or report a bug?

Feature (I think)

What is the current behavior?

licenses commands list both dependencies and devDependencies. This tends to be a huge list if your entire toolchain is installed, and is not helpful (at least to me; I don't care about listing or generating disclaimers for licenses of the tools I use, only my real dependencies).

What is the expected behavior?

licenses should only list the real dependencies.

@sebmck
Copy link
Contributor

sebmck commented Oct 15, 2016

Depending on the licenses of your devDependencies it may actually be required to list them as they were involved in the generation/creation of your code. I think it's safer if we just add a --production flag to yarn licenses that filters these.

sebmck pushed a commit that referenced this issue Oct 15, 2016
@sebmck
Copy link
Contributor

sebmck commented Oct 15, 2016

Created #1104 to fix this, pending approval.

@sebmck sebmck closed this as completed Oct 15, 2016
@sebmck
Copy link
Contributor

sebmck commented Oct 15, 2016

Looks like we actually already support yarn licenses ls --production but it currently mutates the current folder. The PR I've opened addresses this and makes it function as expected.

@Daniel15
Copy link
Member

Good catch! I agree with this - I was going to submit a bug report for it, but I forgot to. Having a --production flag sounds good to me.

sebmck pushed a commit that referenced this issue Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants