Unescapes ESC character, fixing #2439 (#2745)

yarnpkg · Feb 21, 2017 · 3c459de · 3c459de
1 parent 7aaee9b
commit 3c459de
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/__tests__/reporters/base-reporter.js b/__tests__/reporters/base-reporter.js
@@ -113,3 +113,9 @@ test('BaseReporter.disableProgress', () => {
   reporter.disableProgress();
   expect(reporter.noProgress).toBeTruthy();
 });
+
+test('BaseReporter.termstrings', () => {
+  const reporter = new BaseReporter();
+  const expected = '"\u001b[2mjsprim#\u001b[22mjson-schema" not installed';
+  expect(reporter.lang('packageNotInstalled', '\u001b[2mjsprim#\u001b[22mjson-schema')).toEqual(expected);
+});
diff --git a/src/reporters/base-reporter.js b/src/reporters/base-reporter.js
@@ -37,7 +37,10 @@ export function stringifyLangArgs(args: Array<any>): Array<string> {
       return val.inspect();
     } else {
       try {
-        return JSON.stringify(val) || val + '';
+        const str = JSON.stringify(val) || val + '';
+	// should match all "u001b" that follow an odd number of backslashes and convert them to ESC
+	// we do this because the JSON.stringify process has escaped these characters
+        return str.replace(/((?:^|[^\\])(?:\\{2})*)\\u001[bB]/g, '$1\u001b');
       } catch (e) {
         return util.inspect(val);
       }