Fix: Make install.sh Alpine linux compatible #623
Conversation
**Summary** Alpine Linux comes with BusyBox tar, which lacks the `--strip` option. This patch updates the `install.sh` script to not rely on this option. **Test plan** Manually verified on local Ubuntu for Windows.
|
Deploy preview ready! Built with commit 525924e |
install.sh
Outdated
| @@ -33,8 +33,7 @@ yarn_get_tarball() { | |||
| yarn_verify_integrity $tarball_tmp | |||
|
|
|||
| printf "$cyan> Extracting to ~/.yarn...$reset\n" | |||
| mkdir .yarn | |||
| tar zxf $tarball_tmp -C .yarn --strip 1 # extract tarball | |||
| temp=$(mktemp -d) && tar zxf $tarball_tmp -C "$temp" && mkdir .yarn && mv "$temp"/*/* .yarn && rm -rf "$temp" | |||
There was a problem hiding this comment.
Any particular reason for sticking it all on one line?
temp=$(mktemp -d)
tar zxf $tarball_tmp -C "$temp"
mkdir .yarn
mv "$temp"/*/* .yarn
rm -rf "$temp"
There was a problem hiding this comment.
Does sheer laziness count? 😛
Update coming.
|
The deploy preview failing is unrelated, I'll take a look later 👍 |
|
They work now 👌 |
|
@Daniel15 if you're good with the latest changes, merge at will! |
install.sh
Outdated
| @@ -33,7 +33,12 @@ yarn_get_tarball() { | |||
| yarn_verify_integrity $tarball_tmp | |||
|
|
|||
| printf "$cyan> Extracting to ~/.yarn...$reset\n" | |||
| temp=$(mktemp -d) && tar zxf $tarball_tmp -C "$temp" && mkdir .yarn && mv "$temp"/*/* .yarn && rm -rf "$temp" | |||
| # All this dance is because `tar --strip=1` does not work everywhere | |||
There was a problem hiding this comment.
I'd specifically mention Alpine - when I encounter this kind of comment I often wonder what environment is causing issues, so that I can check if that's still the case
There was a problem hiding this comment.
Good thinking but this may not be limited to Alpine. It is mostly all old versions of BusyBox that comes with their own tar.
There was a problem hiding this comment.
It is mostly all old versions of BusyBox
Hmm, I wonder if I could install Yarn on a router. A large number of routers run BusyBox. It's good for environments with very little RAM 😛
Summary
Alpine Linux comes with BusyBox tar, which lacks the
--stripoption. This patch updates theinstall.shscript to not rely on this option.Resolves yarnpkg/yarn#4280.
Test plan
Manually verified on local Ubuntu for Windows.