Add e2e tests for rollup #681
Conversation
| echo ".app { color: red; }" | tee src/style.css | ||
|
|
||
| yarn rollup -c | ||
| [[ "$(cat dist/bundle.css)" = ".style_app__3FC6W { color: red; }" ]] |
There was a problem hiding this comment.
Is the 3FC6W stable? Can it cause the build to periodically fail?
There was a problem hiding this comment.
Since it's a hash of the css file, which means that if we don't change the content of the css file, and the hash function never changed, it would be fine.
However, rollup also do not guarantee that the hashing function would never changed, we could argue that the result is not stable... Maybe we should think of other alternatives, any idea?
There was a problem hiding this comment.
Typically this can be solved by doing a replace operation: | sed 's/__[0-9A-F]+/__xxx/'. This way the result is always stable.
There was a problem hiding this comment.
Maybe a regex approach with =~ would be much cleaner 🤔? I can open up a follow up PR if that sounds good to you 😉
|
That's great! It sounds like the PnP plugin for Rollup isn't even needed anymore as long as one use the CJS plugin? Awesome!
I think Gulp and Nuxt.js would be valuable. Parcel 2 as well, although I'm not 100% sure everything is ready on their side (cc @mischnic / parcel-bundler/parcel#3582?) |
|
Off-topic, but I think our gatsby e2e tests is flawed, I don't think that gatsby work in yarn berry now 🤔, I can open up another issue to track it (or just leave a comment in #368?) |
|
👋 The only blocker at the moment is parcel-bundler/parcel#3210 (plugins aren't resolved relative to the config that specifies them - a shortcut was taken that is now broken because PnP enforces declared deps). |
Sure, open an issue! Note that Gatsby at least used to work, since our website actually uses it (in
Nice! Is it already possible for us to write an E2E that only makes use of parcelrcs without extend? |
If there were a published version with that PR merged, yes. 😬 |
What's the problem this PR addresses?
Add e2e tests for
rollup(#368)Please tell me what other plugins/examples should I add :)