Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): add react native test #6435

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Aug 3, 2024

What's the problem this PR addresses?

React Native uses Yarn v3 in node_modules mode by default now so we should ensure we don't accidentally break that setup.

Ref https://reactnative.dev/blog/2024/04/22/release-0.74#yarn-3-for-new-projects

How did you fix it?

Add a React Native e2e test.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz force-pushed the merceyz/ci/e2e-react-native branch from daed6dd to 07a5ac7 Compare August 3, 2024 17:15
@merceyz
Copy link
Member Author

merceyz commented Aug 3, 2024

Waiting for #6434 to be merged.

@merceyz merceyz marked this pull request as ready for review October 16, 2024 06:39
@merceyz merceyz requested a review from arcanis as a code owner October 16, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant