Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shell): add unset command #6430

Merged
merged 4 commits into from
Aug 25, 2024
Merged

feat(shell): add unset command #6430

merged 4 commits into from
Aug 25, 2024

Conversation

tthijm
Copy link
Contributor

@tthijm tthijm commented Aug 2, 2024

What's the problem this PR addresses?

Fixes #4447.

How did you fix it?

I fixed it by adding an unset built-in.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

merceyz
merceyz requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please adjust the implementation to match the behaviour of the bash built-in unset command.

packages/yarnpkg-shell/sources/index.ts Outdated Show resolved Hide resolved
packages/yarnpkg-shell/sources/index.ts Outdated Show resolved Hide resolved
.yarn/versions/2f8bb76f.yml Outdated Show resolved Hide resolved
packages/yarnpkg-shell/sources/index.ts Outdated Show resolved Hide resolved
@tthijm tthijm requested a review from merceyz August 8, 2024 03:41
merceyz
merceyz approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@merceyz merceyz enabled auto-merge August 25, 2024 14:34
@merceyz merceyz added this pull request to the merge queue Aug 25, 2024
Merged via the queue into yarnpkg:master with commit 10d16c3 Aug 25, 2024
25 of 26 checks passed
@tthijm tthijm deleted the feat-2 branch August 26, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merceyz merceyz merceyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: @yarnpkg/shell doesn't support clearing env variables
2 participants
@tthijm @merceyz