Fix yarn init printing undefined values #643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
This PR fixes #624
To summarize the issue, when running
yarn init
in a new project, the unused fields are all listed with the valueundefined
. This is because inManifest.ts
exportTo
method, fields in thedata
object are being set asundefined
if not used.Here is an example:
How did you fix it?
Now in the
Manifest.ts
exportTo
function, instead of setting unused fields asundefined
they get deleted from thedata
object. The new output looks like this:In order to get proper formatting, the
compact
option is now set tofalse
ininit.ts
executeRegular
. The final output looks like this:Other solutions
This solution touches a lot of code. An easier fix could be adding something like this to the bottom of the
exportTo
function:I opted to go the other route because it seemed more explicit and I think it's better to handle the individual cases closer to the actual logic.