fix(cli): ensure an empty event loop counts as an error #6399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
If the event loop unexpectedly becomes empty
yarn
will terminate with exit code 0 even though the command didn't complete successfully.Ref nodejs/node#53902
Ref #6398 where that happens and the install is incomplete when
yarn
terminates with exit code 0. It's caught in the followingyarn build
step which can't find the install state.How did you fix it?
Set
process.exitCode
to an error code before executing the CLI so an unexpected empty event loop counts as an error.Checklist