Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect node:… module warnings in doctor #6347

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

bradleyayers
Copy link
Contributor

This swaps to use isBuiltin from Node rather than constructing a custom set of module names with node: prefix. For some modules that didn't have a "bare" module (e.g. node:test) this fixes false positive errors.

What's the problem this PR addresses?

Closes #6343

How did you fix it?

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

bradleyayers and others added 2 commits June 15, 2024 20:28
This swaps to use `isBuiltin` from Node rather than constructing a
custom set of module names with `node:` prefix. For some modules that
didn't have a "bare" module (e.g. `node:test`) this fixes false positive
errors.

Closes yarnpkg#6343
@arcanis arcanis merged commit 8445b05 into yarnpkg:master Jun 19, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: node:test not recognised as built-in module by @yarnpkg/doctor
2 participants