Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version) use correct counter placeholder in documentation #6241

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

bgotink
Copy link
Member

@bgotink bgotink commented Apr 19, 2024

What's the problem this PR addresses?

The documentation mentions %d but the code uses %n.

const prerelease = this.prerelease
? typeof this.prerelease !== `boolean` ? this.prerelease : `rc.%n`
: null;

How did you fix it?

Update the code

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 22758ae into master Apr 20, 2024
20 of 24 checks passed
@arcanis arcanis deleted the bgotink/fix/version-doc branch April 20, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants