feat(plugin-typescript): check workspace tsconfig.json

[nmussy]

What's the problem this PR addresses?

Given the following monorepo setup, plugin-typescript is currently not enabled by default in the foo workspace, as it only checks that a tsconfig.json exists at the root of the project:

package.json
workspace/foo/package.json
workspace/foo/tsconfig.json

I also found the current README of plugin-typescript not to be helpful in diagnosing my issue

How did you fix it?

I've added a check to see if the current workspace had a tsconfig.json

I've also added a Configuration section to plugin-typescript/README.md, to help users find the tsEnableAutoTypes option.

Checklist

• I have read the Contributing Guide.

• I have set the packages that need to be released for my changes to be effective.

  • I have only bumped @yarnpkg/plugin-typescript and @yarnpkg/cli, let me know if I should also select the other plugins/core etc.

• I will check that all automated PR checks pass before the PR gets reviewed.

[merceyz]

Suggested change

	?? xfs.existsSync(ppath.join(workspace.cwd, `tsconfig.json`))
	?? xfs.existsSync(ppath.join(project.cwd, `tsconfig.json`));
	?? (xfs.existsSync(ppath.join(workspace.cwd, `tsconfig.json`))
	|| xfs.existsSync(ppath.join(project.cwd, `tsconfig.json`)));

Otherwise it doesn't check the project root as well, if that's on purpose then:

Suggested change

	?? xfs.existsSync(ppath.join(workspace.cwd, `tsconfig.json`))
	?? xfs.existsSync(ppath.join(project.cwd, `tsconfig.json`));
	?? xfs.existsSync(ppath.join(workspace.cwd, `tsconfig.json`));

[nmussy]

Thanks, definitely a bug, it was causing #6175 (comment). I'm still not sure if I should re-introduce it though. If you're in a monorepo, and do not have a tsconfig.json in one of your workspaces, it might be safe to assume you're not using TypeScript in that specific workspace

[merceyz]

If you're in a monorepo, and do not have a tsconfig.json in one of your workspaces, it might be safe to assume you're not using TypeScript in that specific workspace

Not necessarily, this repo is an example of that.

[nmussy]

Alright thanks, that settles it then, it would have been an odd behavior anyway 👍

[nmussy]

The integ tests should be good to go, the builds that failed did so on unrelated specs (https, import, check), and didn't fail for all versions, I don't think this was caused by my changes

[arcanis]

LGTM