Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate docs to Docusaurus v3 #6133

Merged
merged 15 commits into from
Apr 10, 2024
Merged

Migrate docs to Docusaurus v3 #6133

merged 15 commits into from
Apr 10, 2024

Conversation

clemyan
Copy link
Member

@clemyan clemyan commented Feb 20, 2024

What's the problem this PR addresses?

The docs website is on Docsaurus v2 which is not the latest major version

Closes #5918
Closes #6153

How did you fix it?

Migrate to Docsaurus v3.

There are other improvements to the build process and website I'd like to make, but I have left them out and kept most of the logic intact since the migration is quite a large undertaking already.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@RDIL RDIL mentioned this pull request Feb 20, 2024
3 tasks
@clemyan clemyan marked this pull request as draft February 21, 2024 14:12
@clemyan
Copy link
Member Author

clemyan commented Feb 21, 2024

Turns out, the package info page uses some of docusaurus's internal components and is broken after the migration. Marking the PR as draft for now.

@clemyan clemyan force-pushed the docusaurus-v3 branch 2 times, most recently from b1c020b to 0ddac25 Compare February 22, 2024 14:29
@clemyan clemyan marked this pull request as ready for review February 22, 2024 14:36
@arcanis arcanis merged commit c64644a into yarnpkg:master Apr 10, 2024
20 of 24 checks passed
arcanis pushed a commit that referenced this pull request May 2, 2024
**What's the problem this PR addresses?**

#6133 (cc @clemyan) enabled
`noEmit` by default which caused `yarn pack` to not get any build
output.

Fixes #6265

**How did you fix it?**

Explicitly set `noEmit: false` in the build script.

**Checklist**
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.
@clemyan clemyan deleted the docusaurus-v3 branch May 7, 2024 04:25
arcanis pushed a commit that referenced this pull request Jun 20, 2024
## What's the problem this PR addresses?

<!-- Describe the rationale of your PR. -->
<!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->

PR #6133 renamed the contributing file. This PR adjusts sources to
changes.

## How did you fix it?

<!-- A detailed description of your implementation. -->

...

## Checklist

<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [ ] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

Signed-off-by: Emmanuel Ferdman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants