fix(esbuild-plugin-pnp): return resolveDir from onLoad

[alisd23]

A fix in the same area as #4569, for the esbuild-plugin-pnp, regarding the resolveDir property

What's the problem this PR addresses?
Many plugins use the resolveDir argument in the onResolve callback (e.g. to find the absolute path of an imported relative module like in the Remix compiler

Currently, plugins that rely on modules loaded with yarn pnp, get an empty resolveDir passed to the onResolve callback.

It would make sense to, when loading modules with pnp, default the resolveDir to the directory of the current module/file being loaded, as it also lives on disk. This brings us closer in behaviour to the default file namespaced modules too.

How did you fix it?
In the default onLoad callback in the esbuild plugin, we can return the directory the file (args.path) being loaded lives in.

Checklist

• I have read the Contributing Guide.
• I have set the packages that need to be released for my changes to be effective.
• I will check that all automated PR checks pass before the PR gets reviewed.

[alisd23]

@merceyz Out of interest, why is esbuild-plugin-pnp still a release candidate? Is there a specific reason, or should we bump to 3.0.0?

[merceyz]

The release candidates is how we do "canary" releases, the master branch is currently building up to the next major but it isn't ready yet so this PR, among others, will be backported to a stable release.

[alisd23]

Okay cool, makes sense. Also thanks for the speedy review & merge 👍

[merceyz]

No worries and thanks for the fix! I've triggered a new "canary" release so it should be published soon.